ask-password: prevent buffer overflow when reading from keyring
authorThadeu Lima de Souza Cascardo <cascardo@canonical.com>
Mon, 13 May 2019 19:58:01 +0000 (16:58 -0300)
committerMichael Biebl <biebl@debian.org>
Wed, 21 Aug 2019 20:09:13 +0000 (21:09 +0100)
commit6c0ab2b13cde51ebc0849927dc0fc9c8c9a4fb8c
tree035d516064a9739269b6eac95c5d8bfe2aab5281
parent8127a828d2158fb6ac43117cfb008aec12c192d9
ask-password: prevent buffer overflow when reading from keyring

When we read from keyring, a temporary buffer is allocated in order to
determine the size needed for the entire data. However, when zeroing that area,
we use the data size returned by the read instead of the lesser size allocate
for the buffer.

That will cause memory corruption that causes systemd-cryptsetup to crash
either when a single large password is used or when multiple passwords have
already been pushed to the keyring.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
(cherry picked from commit 59c55e73eaee345e1ee67c23eace8895ed499693)

Gbp-Pq: Name ask-password-prevent-buffer-overflow-when-reading-from-ke.patch
src/shared/ask-password-api.c