x86: Fix APIC MSR constant names
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 7 Mar 2018 16:48:01 +0000 (16:48 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 5 Dec 2018 21:01:23 +0000 (21:01 +0000)
commit689bc6244449fd988c32759201668738498ec261
treebca4cfcab1fa949258bc01183dcf40f9555b0e2d
parent17c0293b47b5dc16ae64bbd656acd26fe7d7044b
x86: Fix APIC MSR constant names

We currently have MSR_IA32_APICBASE and MSR_IA32_APICBASE_MSR which are
synonymous from a naming point of view, but refer to very different things.

Rename the x2APIC MSRs to MSR_X2APIC_*, which are shorter constants and
visually separate the register function from the generic APIC name.  For the
case ranges, introduce MSR_X2APIC_LAST, rather than relying on the knowledge
that there are 0x3ff MSRs architecturally reserved for x2APIC functionality.

For functionality relating to the APIC_BASE MSR, use MSR_APIC_BASE for the MSR
itself, but drop the MSR prefix from the other constants to shorten the names.
In all cases, the fact that we are dealing with the APIC_BASE MSR is obvious
from the context.

No functional change (the combined binary is identical).

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Acked-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
xen/arch/x86/apic.c
xen/arch/x86/genapic/x2apic.c
xen/arch/x86/hvm/hvm.c
xen/arch/x86/hvm/vlapic.c
xen/arch/x86/hvm/vmx/vmx.c
xen/include/asm-x86/hvm/vlapic.h
xen/include/asm-x86/msr-index.h