restore p2m_access_t enum order to allow bitmask semantics
authorMalcolm Crossley <malcolm.crossley@citrix.com>
Tue, 15 Mar 2016 11:17:52 +0000 (12:17 +0100)
committerJan Beulich <jbeulich@suse.com>
Tue, 15 Mar 2016 11:17:52 +0000 (12:17 +0100)
commit61a5cfe15dd90b35850fa7359c5c033a1109289e
tree89155cdb689335133f99a4bd76f57ab9bd21ed93
parentc2b9b97775e9de061dd72b22fb96293daaa77f98
restore p2m_access_t enum order to allow bitmask semantics

Nested hap code assumed implict bitmask semantics of the p2m_access_t
enum prior to C/S 4c63692d7c38c5ac414fe97f8ef37b66e05abe5c

The change to the enum ordering broke this assumption and caused functional
problems for the nested hap code. As it may be error prone to audit and find
all other p2m_access users assuming bitmask semantics, instead restore the
previous enum order and make it explict that bitmask semantics are to be
preserved for the read, write and execute access types.

Signed-off-by: Malcolm Crossley <malcolm.crossley@citrix.com>
Reviewed-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: George Dunlap <george.dunlap@citrix.com>
xen/arch/x86/mm/hap/nested_hap.c
xen/include/xen/p2m-common.h