SMB: Validate negotiate (to protect against downgrade) even if signing off
authorSteve French <smfrench@gmail.com>
Thu, 21 Sep 2017 00:57:18 +0000 (19:57 -0500)
committerRaspbian kernel package updater <root@raspbian.org>
Sun, 8 Oct 2017 01:09:36 +0000 (01:09 +0000)
commit61017ea2d01d207db0d1a65f9870c3be08558510
tree651419345304a870acbab7f034b9ba1c5fa75bde
parent1a23127c6d0676877225233d83f5de551c4d80a6
SMB: Validate negotiate (to protect against downgrade) even if signing off

commit 0603c96f3af50e2f9299fa410c224ab1d465e0f9 upstream.

As long as signing is supported (ie not a guest user connection) and
connection is SMB3 or SMB3.02, then validate negotiate (protect
against man in the middle downgrade attacks).  We had been doing this
only when signing was required, not when signing was just enabled,
but this more closely matches recommended SMB3 behavior and is
better security.  Suggested by Metze.

Signed-off-by: Steve French <smfrench@gmail.com>
Reviewed-by: Jeremy Allison <jra@samba.org>
Acked-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Ronnie Sahlberg <lsahlber@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cifs/smb2pdu.c