x86/cpuid: Fix HLE and RTM handling (again)
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 7 Jun 2021 12:25:09 +0000 (13:25 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 7 Jun 2021 14:43:35 +0000 (15:43 +0100)
commit60fa12dbf1d4d2c4ffe1ef34b495b24aa7e41aa0
tree3463604ca07d82d226ee91c59c331c4c580587b2
parentc4beefcada0a406681dcfb6e89f6cbe4aa368c2d
x86/cpuid: Fix HLE and RTM handling (again)

For reasons which are my fault, but I don't recall why, the
FDP_EXCP_ONLY/NO_FPU_SEL adjustment uses the whole special_features[] array
element, not the two relevant bits.

HLE and RTM were recently added to the list of special features, causing them
to be always set in guest view, irrespective of the toolstacks choice on the
matter.

Rewrite the logic to refer to the features specifically, rather than relying
on the contents of the special_features[] array.

Fixes: 8fe24090d9 ("x86/cpuid: Rework HLE and RTM handling")
Reported-by: Edwin Török <edvin.torok@citrix.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/cpuid.c