QSQL/ODBC: fix regression (trailing NUL)
authorDebian Qt/KDE Maintainers <debian-qt-kde@lists.debian.org>
Mon, 13 Nov 2023 08:21:47 +0000 (11:21 +0300)
committerDmitry Shachnev <mitya57@debian.org>
Mon, 13 Nov 2023 08:21:47 +0000 (11:21 +0300)
commit5f70f88ac8b857a85488f39c6877e209e38f7def
tree7dc95c1bc69e1694b3f81ba2e22630263bcb0e00
parentaf2f6ffe4de2fd55281407678b94617ae36e940f
QSQL/ODBC: fix regression (trailing NUL)

Origin: upstream, https://code.qt.io/cgit/qt/qtbase.git/commit/?id=9020034b3b6a3a81
Last-Update: 2023-06-30

When we fixed the callers of toSQLTCHAR() to use the result's size()
instead of the input's (which differ, if sizeof(SQLTCHAR) != 2), we
exposed callers to the append(0), which changes the size() of the
result QVLA. Callers that don't rely on NUL-termination (all?) now saw
an additional training NUL.

Fix by not NUL-terminating, and changing the only user of SQL_NTS to
use an explicit length.

Gbp-Pq: Name sql_odbc_fix_unicode_check.diff
src/plugins/sqldrivers/odbc/qsql_odbc.cpp