improve url download failure display
authorJoey Hess <joeyh@joeyh.name>
Wed, 1 Sep 2021 19:28:22 +0000 (15:28 -0400)
committerJoey Hess <joeyh@joeyh.name>
Wed, 1 Sep 2021 19:33:38 +0000 (15:33 -0400)
commit4f42292b13dc5a6664eeb19b5c9d48991eaef292
treeee1d96833a5f92a1ee8d05917d77771ce77f281f
parent9cd1430fd6da8677541c2ba4ea895d3f65b609bd
improve url download failure display

* When downloading urls fail, explain which urls failed for which
  reasons.
* web: Avoid displaying a warning when downloading one url failed
  but another url later succeeded.

Some other uses of downloadUrl use urls that are effectively internal use,
and should not all be displayed to the user on failure. Eg, Remote.Git
tries different urls where content could be located depending on how the
remote repo is set up. Exposing those urls to the user would lead to wild
goose chases. So had to parameterize it to control whether it displays urls
or not.

A side effect of this change is that when there are some youtube urls
and some regular urls, it will try regular urls first, even if the
youtube urls are listed first. This seems like an improvement if
anything, but in any case there's no defined order of urls that it's
supposed to use.

Sponsored-by: Dartmouth College's Datalad project
Annex/Content.hs
CHANGELOG
Command/AddUrl.hs
Remote/External.hs
Remote/Git.hs
Remote/S3.hs
Remote/Web.hs
doc/todo/get__58___improve_error_reporting_for_failed_attempts.mdwn