[PATCH 2/6] common: Always let QVariant::fromValue() deduce the type
authorManuel Nickschas <sputnick@quassel-irc.org>
Tue, 7 Jan 2020 17:39:48 +0000 (18:39 +0100)
committerFelix Geyer <fgeyer@debian.org>
Fri, 12 Feb 2021 17:40:17 +0000 (17:40 +0000)
commit48faf525fc79913012e1a1aeca0b5124b919eda7
treea15a43455d2ca764ae1ef8e064b1556662bfad23
parente38642601e3006e290e0b6644ed46565588b9ddf
[PATCH 2/6] common: Always let QVariant::fromValue() deduce the type

From 41bf70c263ee0af80ad1850fabe77ffffee188f4 Mon Sep 17 00:00:00 2001
Bug: https://bugs.quassel-irc.org/issues/1544
Bug-Ubuntu: https://bugs.launchpad.net/quassel/+bug/1885436
Origin: upstream, https://github.com/quassel/quassel/pull/518
Origin: upstream, https://github.com/quassel/quassel/commit/41bf70c263ee0af80ad1850fabe77ffffee188f4

In some places, we would explicitly give the type to
QVariant::fromValue(), forgoing automatic type deduction. This is
almost always redundant, and in the cases where it is not, the
input type should be explicitly cast.

Additionally, the implementation of QVariant::fromValue() subtly changed
in Qt 5.14, leading to compile errors when giving a non-decayed type
(as we did in SignalProxy::attachSignal()).

Gbp-Pq: Topic qt514
Gbp-Pq: Name 0002-common-Always-let-QVariant-fromValue-deduce-the-type.patch
19 files changed:
src/client/coreaccountmodel.cpp
src/client/messagefilter.cpp
src/client/messagemodel.cpp
src/client/networkmodel.cpp
src/common/buffersyncer.cpp
src/common/network.cpp
src/common/serializers/serializers.cpp
src/common/types.h
src/common/util.h
src/core/core.cpp
src/qtui/chatitem.cpp
src/qtui/chatlinemodelitem.cpp
src/qtui/mainwin.cpp
src/qtui/settingsdlg.cpp
src/qtui/settingspages/chatmonitorsettingspage.cpp
src/qtui/settingspages/networkssettingspage.cpp
src/qtui/settingspages/shortcutsmodel.cpp
src/uisupport/networkmodelcontroller.cpp
src/uisupport/toolbaractionprovider.cpp