x86/hvm: Disallow the creation of HVM domains without Local APIC emulation
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 2 Mar 2018 15:41:29 +0000 (15:41 +0000)
committerIan Jackson <ijackson@chiark.greenend.org.uk>
Fri, 2 Mar 2018 16:07:18 +0000 (16:07 +0000)
commit45c7d2cdc535f8678842cea321b0119a37d82158
tree9b79f25f6c7fd0a80cc2521ccbaf1fcaf7db0d64
parent5fd1eda78f7f8b6e0f366b84c66025c9c7be9847
x86/hvm: Disallow the creation of HVM domains without Local APIC emulation

There are multiple problems, not necesserily limited to:

 * Guests which configure event channels via hvmop_set_evtchn_upcall_vector(),
   or which hit %cr8 emulation will cause Xen to fall over a NULL vlapic->regs
   pointer.

 * On Intel hardware, disabling the TPR_SHADOW execution control without
   reenabling CR8_{LOAD,STORE} interception means that the guests %cr8
   accesses interact with the real TPR.  Amongst other things, setting the
   real TPR to 0xf blocks even IPIs from interrupting this CPU.

 * On hardware which sets up the use of Interrupt Posting, including
   IOMMU-Posting, guests run without the appropriate non-root configuration,
   which at a minimum will result in dropped interrupts.

Whether no-LAPIC mode is of any use at all remains to be seen.

This is XSA-256.

Reported-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Gbp-Pq: Name x86hvm-disallow-the-creation-of-hvm-doma.patch
xen/arch/x86/domain.c