x86/boot: Annotate the Real Mode entry points
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 1 May 2019 17:14:03 +0000 (18:14 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 13 May 2019 09:35:38 +0000 (10:35 +0100)
commit4597226a356f75e8addee02e87b3a5bae21af8ea
tree3d02ca90137854fb9c6b919c81f7357371bc5725
parent30596213617fcf4dd7b71d244e16c8fc0acf456b
x86/boot: Annotate the Real Mode entry points

... because its already hard enough to follow.  Cross reference the locations
in C which set the entrypoints up, and state the alignment requirements and
entry conditions.

Drop a redundant .align 16, and panic() in do_boot_cpu() if the AP trampoline
isn't set up properly rather than blindly continuing and letting the APs
execute junk, or shifting part of the address into unrelated fields in ICR.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
xen/arch/x86/boot/trampoline.S
xen/arch/x86/boot/wakeup.S
xen/arch/x86/smpboot.c