x86/hvm: Fix HVMOP_get_param when skipping creating the default ioreq server
authorAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 12 Dec 2016 18:12:54 +0000 (18:12 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 13 Dec 2016 09:58:33 +0000 (09:58 +0000)
commit451c9938c68ccb77ff94765f7ac47e8de51d3f43
tree841220f9691c48916366a363b37fb278809d2a4d
parent7190f2d72441b7e5b32004e48398fa6830dd4d99
x86/hvm: Fix HVMOP_get_param when skipping creating the default ioreq server

c/s e7dabe5 "x86/hvm: don't unconditionally create a default ioreq server"
added a break statement, but the logic previously depended on falling through
into the default case to fill in the value the caller asked for.

This causes the sending migration code to put a junk PARAM into the stream,
and the receiving side to fail to zero the IOREQ pages, causing QEMU to object
when it finds stale requests while starting up.

Reorder the code so it more clearly falls through into the default case.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Reviewed-by: Paul Durrant <paul.durrant@citrix.com>
xen/arch/x86/hvm/hvm.c