ipv4: fix null-deref in ipv4_link_failure
authorKyle Zeng <zengyhkyle@gmail.com>
Fri, 15 Sep 2023 05:12:57 +0000 (22:12 -0700)
committerSalvatore Bonaccorso <carnil@debian.org>
Fri, 29 Sep 2023 04:25:15 +0000 (05:25 +0100)
commit444a04e9781f6249517ad568b9334da3d9b3c419
tree8b5af064e18b87c2f75b6b3266933e493b4da2e1
parentf73701cd2f4eeb722a477ee8d7bb199855ad6b9c
ipv4: fix null-deref in ipv4_link_failure

Origin: https://git.kernel.org/pub/scm/linux/kernel/git/stable/stable-queue.git/tree/queue-5.10/ipv4-fix-null-deref-in-ipv4_link_failure.patch

[ Upstream commit 0113d9c9d1ccc07f5a3710dac4aa24b6d711278c ]

Currently, we assume the skb is associated with a device before calling
__ip_options_compile, which is not always the case if it is re-routed by
ipvs.
When skb->dev is NULL, dev_net(skb->dev) will become null-dereference.
This patch adds a check for the edge case and switch to use the net_device
from the rtable when skb->dev is NULL.

Fixes: ed0de45a1008 ("ipv4: recompile ip options in ipv4_link_failure")
Suggested-by: David Ahern <dsahern@kernel.org>
Signed-off-by: Kyle Zeng <zengyhkyle@gmail.com>
Cc: Stephen Suryaputra <ssuryaextr@gmail.com>
Cc: Vadim Fedorenko <vfedorenko@novek.ru>
Reviewed-by: David Ahern <dsahern@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name ipv4-fix-null-deref-in-ipv4_link_failure.patch
net/ipv4/route.c