disable shellescape for rsync 3.2.4
authorJoey Hess <joeyh@joeyh.name>
Tue, 3 May 2022 16:12:25 +0000 (12:12 -0400)
committerJoey Hess <joeyh@joeyh.name>
Tue, 3 May 2022 16:12:41 +0000 (12:12 -0400)
commit43701759a32e38613c61de6dc923c24069f435d6
treeb12923d8e65e771b3d200908290111c8f7807420
parentb760d31be1d6656e74ecf401e57b745764e92849
disable shellescape for rsync 3.2.4

rsync 3.2.4 broke backwards-compatability by preventing exposing filenames
to the shell. Made the rsync and gcrypt special remotes detect this and
disable shellescape.

An alternative fix would have been to always set RSYNC_OLD_ARGS=1.
Which would avoid the overhead of probing rsync --help for each affected
remote. But that is really very fast to run, and it seemed better to switch
to the modern code path rather than keeping on using the bad old code path.

Sponsored-by: Tobias Ammann on Patreon
CHANGELOG
Remote/GCrypt.hs
Remote/Rsync.hs
doc/special_remotes/rsync.mdwn