vTPM: Fix missing NULL check
authorHon Ching \(Vicky) Lo <honclo@linux.vnet.ibm.com>
Wed, 15 Mar 2017 05:28:07 +0000 (01:28 -0400)
committerRaspbian kernel package updater <root@raspbian.org>
Sun, 23 Jul 2017 03:01:35 +0000 (03:01 +0000)
commit4030bac869982aedb7d60265f6331b0763e1f64c
treea6d98f75f35a59c5c275c3b60bced093b871a4ac
parentcbabfdf79d0fbe169151e402438a7e3bd0308947
vTPM: Fix missing NULL check

commit 31574d321c70f6d3b40fe98f9b2eafd9a903fef9 upstream.

The current code passes the address of tpm_chip as the argument to
dev_get_drvdata() without prior NULL check in
tpm_ibmvtpm_get_desired_dma.  This resulted an oops during kernel
boot when vTPM is enabled in Power partition configured in active
memory sharing mode.

The vio_driver's get_desired_dma() is called before the probe(), which
for vtpm is tpm_ibmvtpm_probe, and it's this latter function that
initializes the driver and set data.  Attempting to get data before
the probe() caused the problem.

This patch adds a NULL check to the tpm_ibmvtpm_get_desired_dma.

fixes: 9e0d39d8a6a0 ("tpm: Remove useless priv field in struct tpm_vendor_specific")
Signed-off-by: Hon Ching(Vicky) Lo <honclo@linux.vnet.ibm.com>
Reviewed-by: Jarkko Sakkine <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/char/tpm/tpm_ibmvtpm.c