fix exponential blowup when adding lots of identical files
authorJoey Hess <joeyh@joeyh.name>
Tue, 15 Jun 2021 13:32:12 +0000 (09:32 -0400)
committerJoey Hess <joeyh@joeyh.name>
Tue, 15 Jun 2021 13:45:55 +0000 (09:45 -0400)
commit3af4c9a29aef596765a5391cf80ecd601c8969bd
tree7d8f4d1626b32c2362827fd9ffc433c3a75e2bca
parente147ae07f4841180d420f20ce453a6cb85d8c4e2
fix exponential blowup when adding lots of identical files

This was an old problem when the files were being added unlocked,
so the changelog mentions that being fixed. However, recently it's also
affected locked files.

The fix for locked files is kind of stupidly simple. moveAnnex already
handles populating unlocked files, and only does it when the object file
was not already present. So remove the redundant populateUnlockedFiles
call. (That call was added all the way back in
cfaac52b88e157dd4e71626fe68af37015b9c9bd, and has always been
unncessary.)

Sponsored-by: Dartmouth College's Datalad project
Annex/Ingest.hs
CHANGELOG
doc/bugs/significant_performance_regression_impacting_datal.mdwn
doc/bugs/significant_performance_regression_impacting_datal/comment_33_6e5121e066998a303cf68ebc53e9fc15._comment