default to CertificateValidity::INVALID
authorCaolán McNamara <caolanm@redhat.com>
Mon, 8 Feb 2021 17:05:28 +0000 (17:05 +0000)
committerRene Engelhard <rene@debian.org>
Tue, 28 Nov 2023 19:36:58 +0000 (20:36 +0100)
commit36a598fd8ec058f183b97402063ab6f14ed181dc
tree1c5540f14ee93dfb72290c52b129865ffab9a296
parent17ca73cb624da40cd9899e8c562fece2cc2bcf0b
default to CertificateValidity::INVALID

so if CertGetCertificateChain fails we don't want validity to be
css::security::CertificateValidity::VALID which is what the old default
of 0 equates to

notably

commit 1e0bc66d16aee28ce8bd9582ea32178c63841902
Date:   Thu Nov 5 16:55:26 2009 +0100

    jl137:  #103420# better logging

turned the nss equivalent of SecurityEnvironment_NssImpl::verifyCertificate
from 0 to CertificateValidity::INVALID like this change does

Change-Id: I5350dbc22d1b9b378da2976d3b0abd728f1f4c27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110561
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Gbp-Pq: Name default-to-CertificateValidity::INVALID.diff
xmlsecurity/source/xmlsec/mscrypt/securityenvironment_mscryptimpl.cxx