x86/VT-x: Fix printing of EFER in vmcs_dump_vcpu()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Thu, 31 May 2018 15:57:47 +0000 (16:57 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 5 Jun 2018 10:55:51 +0000 (11:55 +0100)
commit35fcb982ea16c40619fee8bba4789a94d824521e
tree8289ab604166fd711c65ff969fa512dc20039977
parent3960f3a52346348e6b0306f65d19375612bd35b9
x86/VT-x: Fix printing of EFER in vmcs_dump_vcpu()

This is essentially a "take 2" of c/s 82540b66ce "x86/VT-x: Fix determination
of EFER.LMA in vmcs_dump_vcpu()" because in hindight, that change was more
problematic than useful.

The original reason was to fix the logic for determining when not to print the
PDPTE pointers.  However, mutating the efer variable (particularly LME and
LMA) before printing it interferes with diagnosing vmentry failures.

Instead of modifying efer, change the PDPTE conditional to use
VM_ENTRY_IA32E_MODE.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Kevin Tian <kevin.tian@intel.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
xen/arch/x86/hvm/vmx/vmcs.c