Improve http error messages; cleanup
authorChristian Kamm <mail@ckamm.de>
Thu, 23 Mar 2017 14:53:22 +0000 (15:53 +0100)
committerckamm <mail@ckamm.de>
Tue, 4 Apr 2017 07:27:37 +0000 (09:27 +0200)
commit35af03b2e5b68a6a6bfd404f75058a3e0635815e
treef0cb088bafa194a4615c9a618bac56e1606bc4f3
parentae018eab42905c992699794c046ab83db5668eb2
Improve http error messages; cleanup

By default QNetworkReply::errorString() often produces messages like
   "Error downloading <url> - server replied: <reason>"
but the "downloading" part invariably confuses people since the
error might very well have been produced by a PUT request.

This commit produces clearer error messages for HTTP errors.

Additionally:
* Remove some unnecessary null checks from slots connected to
  network job signals and document that these signals never send
  null replies.
* There was a bug where AbstractNetworkJob::_timedout wasn't
  set when derived classes overrode slotTimeout. We now ensure
  it's always set by disallowing overrides of slotTimeout.
  Instead it now calls onTimedOut, which allows custom handling.
* Several subclasses declared errorString, isTimedOut. Move
  these to AbstractNetworkJob.
* Unify handling of OC-ErrorString (via the new, general
  Job::errorString)
* Add documentation in various places.
19 files changed:
src/gui/activitywidget.cpp
src/gui/folderwizard.cpp
src/gui/owncloudsetupwizard.cpp
src/libsync/abstractnetworkjob.cpp
src/libsync/abstractnetworkjob.h
src/libsync/connectionvalidator.cpp
src/libsync/networkjobs.cpp
src/libsync/networkjobs.h
src/libsync/propagatedownload.cpp
src/libsync/propagatedownload.h
src/libsync/propagateremotedelete.cpp
src/libsync/propagateremotedelete.h
src/libsync/propagateremotemkdir.cpp
src/libsync/propagateremotemove.cpp
src/libsync/propagateremotemove.h
src/libsync/propagateupload.cpp
src/libsync/propagateupload.h
src/libsync/propagateuploadng.cpp
src/libsync/propagateuploadv1.cpp