runtime: use -buildmode=pie in testCgoPprofPIE instead of -extldflags=-pie
authorLynn Boger <laboger@linux.vnet.ibm.com>
Fri, 27 Oct 2017 14:06:40 +0000 (10:06 -0400)
committerPeter Michael Green <plugwash@raspbian.org>
Wed, 8 Nov 2017 00:15:02 +0000 (00:15 +0000)
commit335e642e081ff33b55a7e66cb73581421caa2dee
treedb764c983c6f3c92c516b597592a55574e4c6931
parenta29b87a332ea345d01728e62d3cf983025e7a56b
runtime: use -buildmode=pie in testCgoPprofPIE instead of -extldflags=-pie

Errors occur in runtime test testCgoPprofPIE when the test
is built by passing -pie to the external linker with code
that was not built as PIC. This occurs on ppc64le because
non-PIC is the default, and fails only on newer distros
where the address range used for programs is high enough
to cause relocation overflow. This test should be built
with -buildmode=pie since that correctly generates PIC
with -pie.

Related issues are #21954 and #22126.

Updates #22459

Change-Id: Ib641440bc9f94ad2b97efcda14a4b482647be8f7
Reviewed-on: https://go-review.googlesource.com/73970
Run-TryBot: Lynn Boger <laboger@linux.vnet.ibm.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Gbp-Pq: Name 0005-runtime-use-buildmode-pie-in-testCgoPprofPIE-instead.patch
src/runtime/crash_cgo_test.go