libxl: Mark libxl_retrieve_domain_configuration as for external callers only
authorIan Jackson <ian.jackson@eu.citrix.com>
Tue, 4 Oct 2016 09:19:36 +0000 (10:19 +0100)
committerWei Liu <wei.liu2@citrix.com>
Tue, 4 Oct 2016 09:55:21 +0000 (10:55 +0100)
commit2e8bfb005277fd1651ee3ab11f04717abee3d370
treead9c763bf9726518a184df57f2cecad065a1953a
parent031655daea9bb0f69ce54a32fea0eab319471d04
libxl: Mark libxl_retrieve_domain_configuration as for external callers only

This function takes the userdata lock.  Incautious use inside libxl
can result in nested acquisition of that lock, and deadlock.

There is no good reason to use this function inside libxl, but it is a
superficially attractive option.  Make future regressions easier to
spot by marking the function for external use only.

Similar arguments apply for the application-facing userdata accessors,
so do those too.

Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Wei Liu <wei.liu2@citrix.com>
tools/libxl/libxl.h