[PATCH] os/bluestore/BlueFS: use uint64_t for `len`
authorKefu Chai <kchai@redhat.com>
Fri, 28 Jun 2019 03:35:54 +0000 (11:35 +0800)
committerBernd Zeimetz <bzed@debian.org>
Sat, 18 Jan 2020 18:58:32 +0000 (18:58 +0000)
commit2be8ed38f1797d07d7fa7f8e85543b62f860d54e
tree38b956a53303ec37098e29256309ca03dc37f07f
parentabc52fca9058d11f67acd66227b4a462aa303cbb
[PATCH] os/bluestore/BlueFS: use uint64_t for `len`

change the type of parameter `len` of `BlueFS::_read_random()` from
`size_t` to `uint64_t`.

i think the type of `size_t` comes from
`rocksdb::RandomAccessFile::Read(uint64_t offset, size_t n,
rocksdb::Slice* result, char* scratch)`. and when we implement this
method, we continued using `n`'s type. but, we are using it with
`std::min()`, for instance, where the template parameter type deduction
fails if the lhs and rhs parameters' types are different. so probaly the
better solution is to use `uint64_t` directly to avoid the the cast and
specializing the template.

Signed-off-by: Kefu Chai <kchai@redhat.com>
Gbp-Pq: Name bluefs-use-uint64_t-for-len.patch
src/os/bluestore/BlueFS.cc
src/os/bluestore/BlueFS.h