ask-password: prevent buffer overflow when reading from keyring
authorMichael Biebl <biebl@debian.org>
Thu, 27 Jun 2019 13:02:40 +0000 (15:02 +0200)
committerMichael Biebl <biebl@debian.org>
Tue, 20 Aug 2019 11:50:42 +0000 (12:50 +0100)
commit22dbf901e3aed8d24cd415601616aa6c71af0832
treefe6158d410c211b16ce0ef8ee0c7d23e1f0a246a
parent6c1ba931825b0493a3ed48231b2818cee2a481e0
ask-password: prevent buffer overflow when reading from keyring

When we read from keyring, a temporary buffer is allocated in order to
determine the size needed for the entire data. However, when zeroing that area,
we use the data size returned by the read instead of the lesser size allocate
for the buffer.

That will cause memory corruption that causes systemd-cryptsetup to crash
either when a single large password is used or when multiple passwords have
already been pushed to the keyring.

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>
(cherry picked from commit 59c55e73eaee345e1ee67c23eace8895ed499693)

Gbp-Pq: Name ask-password-prevent-buffer-overflow-when-reading-from-ke.patch
src/shared/ask-password-api.c