tools/save: Drop unused parameters from xc_domain_save()
authorAndrew Cooper <andrew.cooper3@citrix.com>
Fri, 3 Jan 2020 18:31:46 +0000 (18:31 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 7 Jan 2020 12:26:45 +0000 (12:26 +0000)
commit2004db3ced18f0ff3114fc72876542b257e9aa6d
tree619a0d6dcc299186c1efc577e6b6acc70e2bdc7d
parentc4f3fc12cd9706f7593016d4daf930cd50f0af32
tools/save: Drop unused parameters from xc_domain_save()

XCFLAGS_CHECKPOINT_COMPRESS has been unused since c/s b15bc4345 (2015),
XCFLAGS_HVM since c/s 9e8672f1c (2013), and XCFLAGS_STDVGA since c/s
087d43326 (2007).  Drop the constants, and code which sets them.

The separate hvm parameter (appeared in c/s d11bec8a1, 2007 and ultimately
redundant with XCFLAGS_HVM), is used for sanity checking and debug printing,
then discarded and replaced with Xen's idea of whether the domain is PV or
HVM.

Rearrange the logic in xc_domain_save() to ask Xen sightly earlier, and use a
consistent idea of 'hvm' throughout.  Removing this parameter removes the
final user of libxl's dss->hvm, so drop that field as well.

Update the doxygen comment to be accurate.

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Acked-by: Ian Jackson <Ian.Jackson@citrix.com>
tools/libxc/include/xenguest.h
tools/libxc/xc_nomigrate.c
tools/libxc/xc_sr_save.c
tools/libxl/libxl_dom_save.c
tools/libxl/libxl_internal.h
tools/libxl/libxl_save_callout.c
tools/libxl/libxl_save_helper.c