x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers
authorAndrew Cooper <andrew.cooper3@citrix.com>
Wed, 24 Jan 2018 16:43:55 +0000 (16:43 +0000)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 3 Sep 2018 18:01:49 +0000 (19:01 +0100)
commit1f0598a1beb6bbaa838dec4f321af543d3b96c7a
tree9dbdf75ba7863250c41c00c7bb9a92d4042e4045
parent4f9b0dbb33aca70cdb61c2988866cbedb4181702
x86/mm: Drop {HAP,SHADOW}_ERROR() wrappers

Unlike the PRINTK/DEBUG wrappers, these go straight out to the console, rather
than ending up in the debugtrace buffer.

A number of these users are followed by domain_crash(), and future changes
will want to combine the printk() into the domain_crash() call.  Expand these
wrappers in place, using XENLOG_ERR before a BUG(), and XENLOG_G_ERR before a
domain_crash().

Perfom some %pv/PRI_mfn/etc cleanup while modifying the invocations, and
explicitly drop some calls which are unnecessary (bad shadow op, and the empty
stubs for incorrect sh_map_and_validate_gl?e() calls).

Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
Reviewed-by: Wei Liu <wei.liu2@citrix.com>
Acked-by: Tim Deegan <tim@xen.org>
xen/arch/x86/mm/hap/hap.c
xen/arch/x86/mm/shadow/common.c
xen/arch/x86/mm/shadow/multi.c
xen/arch/x86/mm/shadow/private.h
xen/include/asm-x86/hap.h