x86/mm: {paging, sh}_{cmpxchg, write}_guest_entry() cannot fault
authorJan Beulich <jbeulich@suse.com>
Mon, 28 Sep 2020 11:57:51 +0000 (13:57 +0200)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Tue, 6 Oct 2020 11:28:37 +0000 (12:28 +0100)
commit1bc30c076a7f1678166934c080e1bf94b2c189af
tree7c6bb824d384ad2ac1f166c30ce38efc8548faa2
parent35679b221ee731a957f180051ede70ef49bb4fe0
x86/mm: {paging, sh}_{cmpxchg, write}_guest_entry() cannot fault

As of 2d0557c5cbeb ("x86: Fold page_info lock into type_info") we
haven't been updating guest page table entries through linear page
tables anymore. All updates have been using domain mappings since then.
Drop the use of guest/user access helpers there, and hence also the
boolean return values of the involved functions.

update_intpte(), otoh, gets its boolean return type retained for now,
as we may want to bound the CMPXCHG retry loop, indicating failure to
the caller instead when the retry threshold got exceeded.

With this {,__}cmpxchg_user() become unused, so they too get dropped.
(In fact, dropping them was the motivation of making the change.)

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Tim Deegan <tim@xen.org>
xen/arch/x86/mm.c
xen/arch/x86/mm/shadow/private.h
xen/arch/x86/mm/shadow/pv.c
xen/arch/x86/pv/mm.h
xen/arch/x86/pv/ro-page-fault.c
xen/include/asm-x86/paging.h
xen/include/asm-x86/x86_64/system.h