libxl: fix cold plugged PCI device with stubdomain
authorMarek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Sat, 28 Sep 2019 14:20:34 +0000 (15:20 +0100)
committerIan Jackson <ian.jackson@eu.citrix.com>
Fri, 4 Oct 2019 16:04:51 +0000 (17:04 +0100)
commit1a734d51902dff44501a7589fdf44d269a55cffd
tree6907ce3005989575624573c4ac3539b70fdce2e0
parent89a854301e815a6f43a695605a5a261d964fcc6b
libxl: fix cold plugged PCI device with stubdomain

When libxl__device_pci_add() is called, stubdomain is already running,
even when still constructing the target domain. Previously, do_pci_add()
was called with 'starting' hardcoded to false, but now do_pci_add() shares
'starting' flag in pci_add_state for both target domain and stubdomain.

Fix this by resetting (local) 'starting' to false in pci_add_dm_done()
(previously part of do_pci_add()) when handling stubdomain, regardless
of pas->starting value.

Fixes: 11db56f9a6 (libxl_pci: Use libxl__ao_device with libxl__device_pci_add)
Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Reviewed-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
Release-acked-by: Juergen Gross <jgross@suse.com>
tools/libxl/libxl_pci.c