mqueue: fix a use-after-free in sys_mq_notify()
authorCong Wang <xiyou.wangcong@gmail.com>
Sun, 9 Jul 2017 20:19:55 +0000 (13:19 -0700)
committerBen Hutchings <ben@decadent.org.uk>
Tue, 19 Sep 2017 01:34:05 +0000 (02:34 +0100)
commit185553b6e8acb88e321cf3b3b3e61358bb57135a
treea2fc01a6a1b86ea1b584520f050a2d1795d3811c
parent0b66b093391cd7d94d90fef03d2c1c4f333a3c7f
mqueue: fix a use-after-free in sys_mq_notify()

The retry logic for netlink_attachskb() inside sys_mq_notify()
is nasty and vulnerable:

1) The sock refcnt is already released when retry is needed
2) The fd is controllable by user-space because we already
   release the file refcnt

so we when retry but the fd has been just closed by user-space
during this small window, we end up calling netlink_detachskb()
on the error path which releases the sock again, later when
the user-space closes this socket a use-after-free could be
triggered.

Setting 'sock' to NULL here should be sufficient to fix it.

Reported-by: GeneBlue <geneblue.mail@gmail.com>
Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Manfred Spraul <manfred@colorfullife.com>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name mqueue-fix-a-use-after-free-in-sys_mq_notify.patch
ipc/mqueue.c