rofiles-fuse: also pass mode for O_RDONLY
authorJonathan Lebon <jlebon@redhat.com>
Wed, 20 Sep 2017 18:38:16 +0000 (18:38 +0000)
committerSimon McVittie <smcv@debian.org>
Fri, 22 Sep 2017 14:48:24 +0000 (15:48 +0100)
commit15fc7b8b28be1f277cf78159fdb84e207b5fd31f
treeaf5a13f35969b4545857746d46af42475bbd429d
parentf7c168aceac899dc50944614d8cffd5787f6cfe6
rofiles-fuse: also pass mode for O_RDONLY

In the `O_RDONLY` case, we were calling `openat` without a mode
argument. However, it's perfectly legal (albeit unusual) to do
`open(O_RDONLY|O_CREAT)`. One such application that makes use of this is
`flock(1)`.

This was actually caught by `_FORTIFY_SOURCE=2`, and once we run
`rofiles-fuse` with `-f`, the message is clear:

```
*** invalid openat64 call: O_CREAT or O_TMPFILE without mode ***:
rofiles-fuse terminated
======= Backtrace: =========
/lib64/libc.so.6(+0x7c8dc)[0x7f36d9f188dc]
/lib64/libc.so.6(__fortify_fail+0x37)[0x7f36d9fbfaa7]
/lib64/libc.so.6(+0x10019a)[0x7f36d9f9c19a]
rofiles-fuse[0x401768]
...
```

Without `_FORTIFY_SOURCE`, the file gets created, but its mode is
completely random.

I ran into this while investigating
https://github.com/projectatomic/rpm-ostree/pull/1003.

Closes: #1200
Approved by: cgwalters
Origin: upstream, 2017.12, commit:d4c7093e370843c57eab2f89f0c39ef449e6b32e

Gbp-Pq: Topic 2017.12
Gbp-Pq: Name rofiles-fuse-also-pass-mode-for-O_RDONLY.patch
src/rofiles-fuse/main.c
tests/test-rofiles-fuse.sh