tools/lib/api/fs/fs.c: Fix misuse of strncpy()
authorBen Hutchings <ben@decadent.org.uk>
Thu, 19 Jul 2018 22:36:52 +0000 (23:36 +0100)
committerBen Hutchings <ben@decadent.org.uk>
Fri, 23 Nov 2018 19:15:55 +0000 (19:15 +0000)
commit10c0bcf70c75ed2db785f865ae637022d29e2035
tree36ca08b55eac2415921edc528bbc8db3685943a6
parent3220fbce72708a6589f69ad58fb0ad4862f79fc5
tools/lib/api/fs/fs.c: Fix misuse of strncpy()

gcc 8 reports:

In function 'fs__env_override',
    inlined from 'fs__get_mountpoint' at fs/fs.c:228:6:
fs/fs.c:222:2: error: 'strncpy' specified bound 4096 equals destination size [-Werror=stringop-truncation]
  strncpy(fs->path, override_path, sizeof(fs->path));
  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

I'm not convinced it makes sense to truncate the copied string here,
but since we're already doing so let's ensure it's still null-
terminated.  Use strlcpy() instead.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name tools-lib-api-fs-fs.c-fix-misuse-of-strncpy.patch
tools/lib/api/fs/fs.c