x86/APIC: drop probe_default()
authorJan Beulich <jbeulich@suse.com>
Fri, 5 Nov 2021 12:34:57 +0000 (13:34 +0100)
committerAndrew Cooper <andrew.cooper3@citrix.com>
Mon, 29 Nov 2021 13:53:05 +0000 (13:53 +0000)
commit0ee901ce4b439ef5a44bf6ac7471e75a20dffbbe
tree255ccb987705a5eb6635971e773bc41263de2bd5
parent501f70b16a09983b6f8a1fb65757f26ec239a017
x86/APIC: drop probe_default()

The function does nothing but return success. Simply treat absence of a
probe hook to mean just this. This then eliminates the (purely
theoretical at this point) risk of trying to call through
apic_x2apic_{cluster,phys}'s respective NULL pointers.

While doing this also eliminate generic_apic_probe()'s "changed"
variable: apic_probe[]'s default entry will now be used unconditionally
in yet more obvious a way, such that separately setting genapic from
apic_default is (hopefully) no longer justified. Yet that was the main
purpose of the variable.

To help prove that apic_default's probe() hook doesn't get used
elsewhere, further make apic_probe[] static at this occasion.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Andrew Cooper <andrew.cooper3@citrix.com>
xen/arch/x86/genapic/default.c
xen/arch/x86/genapic/probe.c