x86/hvm: don't leave emulator in inconsistent state
authorJan Beulich <jbeulich@suse.com>
Thu, 26 Jul 2012 15:51:51 +0000 (16:51 +0100)
committerJan Beulich <jbeulich@suse.com>
Thu, 26 Jul 2012 15:51:51 +0000 (16:51 +0100)
commit09dc3b63b3edd989e7de6f7aaa2fa24f6996aab2
tree0a989e3f90ad26272a2ee40a5c5fb190c09d3ac7
parentd82a726d153bdd9de98cdab27ed2f4e1d8eb47a1
x86/hvm: don't leave emulator in inconsistent state

The fact that handle_mmio(), and thus the instruction emulator, is
being run through twice for emulations that require involvement of the
device model, allows for the second run to see a different guest state
than the first one. Since only the MMIO-specific emulation routines
update the vCPU's io_state, if they get invoked on the second pass,
internal state (and particularly this variable) can be left in a state
making successful emulation of a subsequent MMIO operation impossible.

Consequently, whenever the emulator invocation returns without
requesting a retry of the guest instruction, reset io_state.

Signed-off-by: Jan Beulich <jbeulich@suse.com>
Acked-by: Keir Fraser <keir@xen.org>
Committed-by: Ian Jackson <ian.jackson@eu.citrix.com>
xen/arch/x86/hvm/io.c