xl: Return an error on failed cd-insert
authorGeorge Dunlap <george.dunlap@eu.citrix.com>
Thu, 24 Mar 2016 17:17:24 +0000 (17:17 +0000)
committerKonrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Fri, 25 Mar 2016 19:51:16 +0000 (15:51 -0400)
commit04119085f5a2a135e5161535b8821e1aa0d7db8a
tree4aa7029a73973de6ec4361232d0378b78562c372
parent0614c454209ac67016e2296577abfee9e9dcb012
xl: Return an error on failed cd-insert

This makes xl more useful in scripts.

The strange thing about this is that the internal cd_insert function
*already* returned something appropriate, and cd-eject was using it,
but cd-insert wasn't.

Also:

* Rework cd_insert to return EXIT_FAILURE and EXIT_SUCCESS rather than
magic constants

* Use 'r' for non-libxl return code, as specified in CODING_STYLE

Signed-off-by: George Dunlap <george.dunlap@eu.citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
tools/libxl/xl_cmdimpl.c