PropagateDownload: fix possible crash
authorOlivier Goffart <ogoffart@woboq.com>
Tue, 28 Mar 2017 13:21:59 +0000 (15:21 +0200)
committerMarkus Goetz <markus@woboq.com>
Tue, 28 Mar 2017 16:04:19 +0000 (18:04 +0200)
commit039ff0ca8e5e5fe175ca79d1ae9d62505644391b
treecb1d4e24ddc264096d26085a2d83d89397081b3f
parent85afa4788b7ad16d1959a9660ba16b4393601345
PropagateDownload: fix possible crash

Backtrace looks like this:
Crash: EXCEPTION_ACCESS_VIOLATION_READ at 0x0
  File "propagatedownload.cpp", line 234, in OCC::GETFileJob::slotReadyRead
  File "moc_propagatedownl_CA5CFSHZDTX34X.cpp", line 86, in OCC::GETFileJob::qt_static_metacall
  File "qobject.cpp", line 495, in QMetaCallEvent::placeMetaCall
  File "qobject.cpp", line 1256, in QObject::event
  File "qapplication.cpp", line 3804, in QApplicationPrivate::notify_helper

GETFileJob::slotReadyRead can be called with a QueuedConnection when the
bendwith manager is involved. In that case, if the QNAM was reset
in between, the reply might have been destroyed.
(This is only speculation based on the backtrace)
src/libsync/propagatedownload.cpp