perf/core: Fix a memory leak in perf_event_parse_addr_filter()
authorkiyin(尹亮) <kiyin@tencent.com>
Wed, 4 Nov 2020 05:23:22 +0000 (08:23 +0300)
committerSalvatore Bonaccorso <carnil@debian.org>
Sun, 8 Nov 2020 12:40:04 +0000 (12:40 +0000)
commit0361b56aae3fa061b79f81be16a1580d62696891
treeb32fcce859bdfe72c1c5297ab96c63359645a095
parent35e6ed704c7429a375be952c666d2c1abf73e186
perf/core: Fix a memory leak in perf_event_parse_addr_filter()

Origin: https://git.kernel.org/linus/7bdb157cdebbf95a1cd94ed2e01b338714075d00

As shown through runtime testing, the "filename" allocation is not
always freed in perf_event_parse_addr_filter().

There are three possible ways that this could happen:

 - It could be allocated twice on subsequent iterations through the loop,
 - or leaked on the success path,
 - or on the failure path.

Clean up the code flow to make it obvious that 'filename' is always
freed in the reallocation path and in the two return paths as well.

We rely on the fact that kfree(NULL) is NOP and filename is initialized
with NULL.

This fixes the leak. No other side effects expected.

[ Dan Carpenter: cleaned up the code flow & added a changelog. ]
[ Ingo Molnar: updated the changelog some more. ]

Fixes: 375637bc5249 ("perf/core: Introduce address range filtering")
Signed-off-by: "kiyin(尹亮)" <kiyin@tencent.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: "Srivatsa S. Bhat" <srivatsa@csail.mit.edu>
Cc: Anthony Liguori <aliguori@amazon.com>
--
 kernel/events/core.c | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

Gbp-Pq: Topic bugfix/all
Gbp-Pq: Name perf-core-Fix-a-memory-leak-in-perf_event_parse_addr.patch
kernel/events/core.c