clutter-offscreen-effect: Disable if no texture
authorDaniel van Vugt <daniel.van.vugt@canonical.com>
Thu, 11 Oct 2018 07:02:05 +0000 (07:02 +0000)
committerSimon McVittie <smcv@debian.org>
Wed, 6 Feb 2019 10:02:14 +0000 (10:02 +0000)
commit02c8f9901165fdc5d5959d4b182d933edf252370
tree6bd6e13674ad9820a72319a2aad479c730ffc5ee
parent696d78395b7e45813a4aded328a10d1957bbf908
clutter-offscreen-effect: Disable if no texture

If texture allocation fails (e.g. on an old GPU with size limit 2048)
then `update_fbo` would return `FALSE` but leaves `priv->offscreen`
as non-NULL. So the next paint will try to use the offscreen with a
`NULL` texture and crashes. The solution is simply to ensure that
`priv->offscreen` is NULL if there is no `priv->texture`, so the default
(non-offscreen) paint path gets used instead.

Bug reported and fix provided by Gert van de Kraats.

(cherry picked from commit f31cf0c3ef99b27c0b2c0161fc9fc1eb82778b2e)

(cherry picked from commit 1b78ca8c5eef39831639a0bde8d613cd1bb024dc)

Bug-Ubuntu: https://launchpad.net/bugs/1795774
Applied-upstream: 3.30.3, commit:c6223ffea87831f9bd51d11c50e953f0318459e0

Gbp-Pq: Name clutter-offscreen-effect-Disable-if-no-texture.patch
clutter/clutter/clutter-offscreen-effect.c