autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL
authorNeilBrown <neilb@suse.com>
Fri, 23 Jun 2017 22:08:43 +0000 (15:08 -0700)
committerRaspbian kernel package updater <root@raspbian.org>
Sun, 23 Jul 2017 03:02:06 +0000 (03:02 +0000)
commit0200546fde9cc4e6d51a0c5ebc80a18c6acacf9e
tree58b190643913c0cbcc4fbb08c5f10e58d56c8e2e
parent08fbf981a26119304db4d9bd5ab70ecc239c46db
autofs: sanity check status reported with AUTOFS_DEV_IOCTL_FAIL

commit 9fa4eb8e490a28de40964b1b0e583d8db4c7e57c upstream.

If a positive status is passed with the AUTOFS_DEV_IOCTL_FAIL ioctl,
autofs4_d_automount() will return

   ERR_PTR(status)

with that status to follow_automount(), which will then dereference an
invalid pointer.

So treat a positive status the same as zero, and map to ENOENT.

See comment in systemd src/core/automount.c::automount_send_ready().

Link: http://lkml.kernel.org/r/871sqwczx5.fsf@notabene.neil.brown.name
Signed-off-by: NeilBrown <neilb@suse.com>
Cc: Ian Kent <raven@themaw.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/autofs4/dev-ioctl.c