vchan-socket-proxy: Move perror() into listen_socket
authorJason Andryuk <jandryuk@gmail.com>
Thu, 11 Jun 2020 03:29:28 +0000 (23:29 -0400)
committerWei Liu <wl@xen.org>
Fri, 26 Jun 2020 11:59:38 +0000 (11:59 +0000)
commit01b9a28e7d1dc54968d5081bdc089449052df939
treeb3812d3307930f6efd8554afb8095debb19c1467
parent2c8ac47d4e780389842f812bb6b2f95fa673add5
vchan-socket-proxy: Move perror() into listen_socket

The use of perror on the return from listen_socket can produce
misleading results like:
UNIX socket path "/tmp/aa....aa" too long (156 >= 108)
listen socket: Success

errno is reset by subsequent system & library calls, so it may be
inaccurate by the time listen_socket returns.  Call perror immediately
after failing system calls to print the proper message.

Signed-off-by: Jason Andryuk <jandryuk@gmail.com>
Acked-by: Wei Liu <wl@xen.org>
Reviewed-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Release-acked-by: Paul Durrant <paul@xen.org>
tools/libvchan/vchan-socket-proxy.c