clutter-offscreen-effect: Disable if no texture
authorDaniel van Vugt <daniel.van.vugt@canonical.com>
Thu, 11 Oct 2018 07:02:05 +0000 (09:02 +0200)
committerMarco Trevisan (Treviño) <marco@ubuntu.com>
Thu, 24 Jan 2019 18:00:14 +0000 (18:00 +0000)
commit00bf19781edd79082e5bca3ce0107cdd19d61093
tree9f9a5214bb3d403ad1293fc7a22a10c2b4382b93
parenta8d75a67fd6f7f9f1ebdccc374951d4b4346970b
clutter-offscreen-effect: Disable if no texture

If texture allocation fails (e.g. on an old GPU with size limit 2048)
then `update_fbo` would return `FALSE` but leaves `priv->offscreen`
as non-NULL. So the next paint will try to use the offscreen with a
`NULL` texture and crashes. The solution is simply to ensure that
`priv->offscreen` is NULL if there is no `priv->texture`, so the default
(non-offscreen) paint path gets used instead.

Bug reported and fix provided by Gert van de Kraats.

Origin: https://gitlab.gnome.org/GNOME/mutter/commit/f31cf0c3e
Bug-Ubuntu: https://launchpad.net/bugs/1795774
Applied-upstream: 3.30.3

Gbp-Pq: Name clutter-offscreen-effect-Disable-if-no-texture.patch
clutter/clutter/clutter-offscreen-effect.c